-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix import wizard #11842
Fix import wizard #11842
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It works fine on community, but on commercial it fails with
RecursionError at /dashboard/import/manual/
maximum recursion depth exceeded
It seems that wizard.get_step_index()
calls self.steps.current
, which calls again show_config_step
😢
I wasn't able to replicate that in tests, did you rebuild your docker image with to use the latest version of the dependency? |
Are you able to reproduce this by importing a project?
Yes. |
I pushed a commit here that combined with https://github.com/readthedocs/readthedocs-corporate/pull/1920 make the wizard import to work locally. I feel that the condition dict option is completely broken, tho and we should probably consider to go back to my original hack 😄 |
I was able to manually import a project before my computer's battery died, but didn't get to test the import from a remote repo part. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's try this solution and see how it goes.
I think this fixes it (at least makes .com tests green), but we don't have tests for this, so not sure if it doesn't break anything else. @humitos you may want to test it locally.
ref https://read-the-docs.sentry.io/issues/6127455073/?project=161479&query=is%3Aunresolved&referrer=issue-stream&sort=trends&statsPeriod=90d&stream_index=3