Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix import wizard #11842

Merged
merged 5 commits into from
Dec 12, 2024
Merged

Fix import wizard #11842

merged 5 commits into from
Dec 12, 2024

Conversation

stsewd
Copy link
Member

@stsewd stsewd commented Dec 11, 2024

I think this fixes it (at least makes .com tests green), but we don't have tests for this, so not sure if it doesn't break anything else. @humitos you may want to test it locally.

ref https://read-the-docs.sentry.io/issues/6127455073/?project=161479&query=is%3Aunresolved&referrer=issue-stream&sort=trends&statsPeriod=90d&stream_index=3

@stsewd stsewd requested a review from a team as a code owner December 11, 2024 01:26
@stsewd stsewd requested a review from humitos December 11, 2024 01:26
Copy link
Member

@humitos humitos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works fine on community, but on commercial it fails with

RecursionError at /dashboard/import/manual/
maximum recursion depth exceeded

It seems that wizard.get_step_index() calls self.steps.current, which calls again show_config_step 😢

@stsewd
Copy link
Member Author

stsewd commented Dec 11, 2024

It works fine on community, but on commercial it fails with

RecursionError at /dashboard/import/manual/
maximum recursion depth exceeded

It seems that wizard.get_step_index() calls self.steps.current, which calls again show_config_step 😢

I wasn't able to replicate that in tests, did you rebuild your docker image with to use the latest version of the dependency?

@humitos
Copy link
Member

humitos commented Dec 11, 2024

I wasn't able to replicate that in tests

Are you able to reproduce this by importing a project?

did you rebuild your docker image with to use the latest version of the dependency?

Yes.

@humitos
Copy link
Member

humitos commented Dec 11, 2024

I pushed a commit here that combined with https://github.com/readthedocs/readthedocs-corporate/pull/1920 make the wizard import to work locally.

I feel that the condition dict option is completely broken, tho and we should probably consider to go back to my original hack 😄

@stsewd
Copy link
Member Author

stsewd commented Dec 11, 2024

Are you able to reproduce this by importing a project?

I was able to manually import a project before my computer's battery died, but didn't get to test the import from a remote repo part.

Copy link
Member

@humitos humitos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's try this solution and see how it goes.

@humitos humitos merged commit 400e17d into main Dec 12, 2024
8 checks passed
@humitos humitos deleted the fix-wizard branch December 12, 2024 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants