Use environment file for initial conda env creation. #1947
Conversation
|
|
||
| # Use conda for requirements it packages | ||
| requirements = [ | ||
| 'sphinx==1.3.1', | ||
| 'Pygments==2.0.2', | ||
| 'docutils==0.11', | ||
| 'mock==1.0.1', | ||
| 'docutils', |
There was a problem hiding this comment.
Couple of questions. Is it really ok to leave docutils unpinned or should it just be pinned to a newer version like 0.12? Also, should mock really be dropped?
There was a problem hiding this comment.
The idea of including mock was to let folks mock dependencies, which presumably isn't an issue with conda.
We could also remove docutils entirely, and let Sphinx specify the docutils version. Not sure the best path forward.
There was a problem hiding this comment.
Ah, ok. So, you are not dependent on mock. In that case, I agree with you. Also, letting sphinx pull in docutils sounds fine unless you are using it internally somehow.
There was a problem hiding this comment.
I've gone ahead and pinned it at 0.12 for now, as that's the least disruptive to how everything else works.
There was a problem hiding this comment.
Sorry to keep nitpicking on this, but if you are concerned about disruption then should the mock constraint simply be left as is?
|
Tests pass locally, think this is just Travis failing. |
|
I've retriggered tests, if they are still failing I'll try to verify, but I'm assuming this is just travis flaking out as well |
|
Another thing to consider, there is a |
Use environment file for initial conda env creation.
Fixes #1901