Upgrade Sphinx version and theme. #2676
Conversation
I did some basic builds locally that looked and worked fine, and we have a lot of users using 1.5 in requirements files. We don't have a great way to stress test this, but I think we should definitely push it out as a default.
ericholscher
added
the
PR: work in progress
| @@ -2,7 +2,7 @@ | |||
| pip==8.1.1 | |||
| virtualenv==15.0.1 | |||
| docutils==0.11 | |||
| Sphinx==1.3.5 | |||
| Sphinx==1.5.3 | |||
There was a problem hiding this comment.
I'm not sure if we still even need these as requirements for the code, since all the Sphinx interaction happens inside Docker. I guess for non-docker installs it's still required, so might as well update it.
| @@ -102,7 +102,7 @@ def setup_base(self): | |||
|
|
|||
| def install_core_requirements(self): | |||
| requirements = [ | |||
| 'sphinx==1.3.5', | |||
| 'sphinx==1.5.2', | |||
There was a problem hiding this comment.
Ha, didn't see it was released -- also this was an old commit :)
|
For some reason Travis is not loading
and I can't see why it's failing. |
|
Yea, looks like their web UI is borked. I'm guessing it's probably fine (given one of the tests is passing). The bigger issue will be seeing how it works in production throwing it against a whole pile of user data :) |
|
Yeah, and also those projects that works with 1.3.5 but not with a newer one (if that it's possible) and don't have Sphinx pinned... will be a mess. They will be force to create the reqs file or upgrade their docs. |
|
Yea, there are some backwards incompatible changes in Sphinx -- hopefully a lot of folks are pinning their requirements in this case, but it will likely break for some folks. Not a whole lot we can do about that though :/ |
|
The Travis build seems borked for other reasons. Merging this. |
ericholscher
removed
the
PR: work in progress
I did some basic builds locally that looked and worked fine,
and we have a lot of users using 1.5 in requirements files.
We don't have a great way to stress test this,
but I think we should definitely push it out as a default.
I didn't touch the conda defaults because it doesn't update as quickly as pypi.