formatting buttons in edit project text editor #3633
Conversation
|
Firstly, thank you very much for the first-time contribution! This does in fact fix the RST editor and it worked for me. However, I had a question about the minified file Ideally, this plugin should come from bower or NPM but perhaps it's best to merge this PR once we've verified the pack file and then switch to loading it from bower in a separate PR. Edit: bower or NPM |
RichardLitt
added
the
PR: work in progress
|
I'm even starting to wonder whether we need this description field at all. It only shows up on project pages and isn't really used to do anything. |
|
Thanks for the review. Regarding pack file, I did it online using the actual jquery.markitup.js file. |
|
Yes, the significance of description field is another design question. |
|
I'd be +1 on removing it. It's a bunch of code for a small field, which most people will just be copying from a README file or similar. Sorry to invalidate the work you did @aasis21, but if you could just remove the files, I'd be happy to commit it! Thanks for making the effort, allowing us to have this discussion. |
|
No problems @ericholscher, I'd be happy to do that. So, what you are saying is to completely remove the description feature from the project. Am I right? |
|
I think this PR should be scaled back to just remove the markitup dependency. We can keep a description field for now. Removing this will be a larger chunk of work and requires us to make a design decision around this. We'll want to review the UI changes that this entails for before just removing. I've have been wanting to get rid of this field for a long time however. I don't think we need it, or any project description on our dashboard page -- this isn't a page that readers see. I've opened #3689 for core to discuss removing the field. |
| <link rel="stylesheet" type="text/css" href="{{ MEDIA_URL }}lib/markitup/sets/sphinx/editor.css" /> | ||
| {% endblock %} | ||
|
|
||
| {% block dash-nav-create %}active{% endblock %} |
There was a problem hiding this comment.
This is a required line.
There was a problem hiding this comment.
Sorry, it was removed by mistake. Thanks for pointing out.
|
Thanks, @agjohnson for clarifying the situation. I have made changes as you suggested. |
|
Thanks so much for this PR @aasis21! I love PR's that delete code, and this one deletes a lot :) |
|
Thanks @ericholscher |
#3629
Now, the formatting buttons now show its corresponding rst on the editor.