-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use pur to upgrade python packages #3953
Conversation
humitos
commented
Apr 16, 2018
requirements/pip.txt
Outdated
Sphinx==1.7.0 | ||
sphinx_rtd_theme==0.2.5b1 | ||
Sphinx==1.7.2 | ||
sphinx_rtd_theme==0.3.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should wait until readthedocs/sphinx_rtd_theme#610 is solved, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good call. Let's hold off on this one for now. I'm going to try to get the issues around this resolved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will stick in 0.2.5b1
until that issue is solved.
@@ -19,20 +19,20 @@ readthedocs-build<2.1 | |||
# django-tastypie 0.13.x and 0.14.0 are not compatible with our code | |||
django-tastypie==0.13.0 | |||
|
|||
django-haystack==2.7.0 | |||
django-haystack==2.8.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is only used on the API v1, is still worth updating? 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't this used for elasticsearch?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No. It's only for v1 API which we should deprecate.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, though I do worry about breaking stuff that isn't well tested (eg. Docker). It's good to keep these up to date though, so I'm +1 on merging it and then doing dev with it for a while before deploying.
I did some tests locally running different builds and it worked. The good side is that we have a newer version of docker daemon in our servers so it's more likely to be compatible without changes. |