fixing the indexing #4615
Merged
fixing the indexing #4615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericholscher
approved these changes
Sep 6, 2018
ericholscher
requested changes
Sep 6, 2018
There was a problem hiding this comment.
We need to update the signal here too: https://github.com/rtfd/readthedocs.org/blob/eric-search-upgrade/readthedocs/search/signals.py#L25
| data = { | ||
| 'app_label': app_label, | ||
| 'model_name': model_name, | ||
| 'document_class': document_class, | ||
| 'index_name': index_name, | ||
| 'objects_id': list(chunk) | ||
| 'objects_id': chunk |
There was a problem hiding this comment.
This should be named chunk I think?
|
I think we probably need to support both a list of object ID's for normal running, and also a start/end for reindexing perhaps |
|
@ericholscher Oops! I missed that! |
ericholscher
reviewed
Sep 6, 2018
readthedocs/search/tasks.py
Outdated
| def index_objects_to_es(app_label, model_name, document_class, index_name, | ||
| chunk=None, objects_id=None): | ||
|
|
||
| assert not chunk and objects_id, "You can not pass both chunk and objects_id" |
There was a problem hiding this comment.
Think this needs a (chunk and objects_id) to apply not properly.
There was a problem hiding this comment.
@ericholscher fixed!
|
👍 |
safwanrahman
pushed a commit
to safwanrahman/readthedocs.org
that referenced
this pull request
Sep 15, 2018
fixing the indexing
safwanrahman
pushed a commit
to safwanrahman/readthedocs.org
that referenced
this pull request
Sep 15, 2018
fixing the indexing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ericholscher It should fix the search indexing!