Allow to change project's VCS #4845
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stsewd
force-pushed
the
allow-change-vcs
branch
from
19ae374 to
629a5af
Compare
Codecov Report
@@ Coverage Diff @@
## master #4845 +/- ##
==========================================
+ Coverage 76.27% 76.34% +0.07%
==========================================
Files 158 158
Lines 9981 9981
Branches 1261 1260 -1
==========================================
+ Hits 7613 7620 +7
+ Misses 2024 2020 -4
+ Partials 344 341 -3
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4844
More background on #1170
So, previously this wasn't so important, users could just change the
default_branchto whatever they want (master in this case). But, with #4710 they can't do that anymore and the only solution is to recreate the project.I know this isn't a common case (changing VCS), but if the user chooses by mistake the wrong VCS when creating the project, then the user is in trouble.