Delete tags with same commit #4915
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4915 +/- ##
==========================================
- Coverage 76.65% 76.64% -0.01%
==========================================
Files 158 158
Lines 10059 10055 -4
Branches 1269 1267 -2
==========================================
- Hits 7711 7707 -4
Misses 2007 2007
Partials 341 341
|
stsewd
commented
Nov 20, 2018
| @@ -105,12 +105,13 @@ def test_new_tag_update_active(self): | |||
| self.pip.get_stable_version().identifier, | |||
| ) | |||
|
|
|||
| def test_new_tag_update_inactive(self): | |||
| def test_new_tag_dont_update_inactive(self): | |||
There was a problem hiding this comment.
Finally, I was able to fix and understand why this test was failing, first this test is wrong, why? Because our current logic says (and do)
why the test was passing?
Because the version was created with type='unknown', so it was being skipped here
Why the test fail now?
Because we are filtering by branches and tags only, so the unknown version was being deleted.
stsewd
removed
the
PR: work in progress
ericholscher
approved these changes
Nov 20, 2018
| @@ -105,12 +105,13 @@ def test_new_tag_update_active(self): | |||
| self.pip.get_stable_version().identifier, | |||
| ) | |||
|
|
|||
| def test_new_tag_update_inactive(self): | |||
| def test_new_tag_dont_update_inactive(self): | |||
humitos
approved these changes
Nov 20, 2018
|
Tested this locally, merging. I'll put this to the deploy checks, I guess that our docs have some old tags from the pass release, right? If so, when building our docs those tags should disappear p: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This only happens with tags, because they are basically an alias for a commit, so it can be several tags pointing to the same commit or identifier.
We exclude branches and tags by its identifier
https://github.com/rtfd/readthedocs.org/blob/4031b9078efba9948301e89c948a236671086d26/readthedocs/restapi/utils.py#L144-L144
I can confirm that the other VCS share the same concept for tags
Git: we already know we can have several tags pointing to the same commit
Mercurial: I didn't find anything about this in the docs https://www.mercurial-scm.org/wiki/Tag, but here says that it's possible http://hgbook.red-bean.com/read/managing-releases-and-branchy-development.html
Bazaar: From the docs http://wiki.bazaar.canonical.com/Specs/Tagging
Subversion: it doesn't support tags
Fix #4875