Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppress progress bar of the conda command. #5094

Merged
merged 3 commits into from
Jan 14, 2019
Merged

Suppress progress bar of the conda command. #5094

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6f0f19f
Suppress progress bar of the conda command.
rainwoodman Jan 11, 2019
d5e734e
Update tests.
rainwoodman Jan 13, 2019
2cb6e76
Update test_doc_building.py
rainwoodman Jan 14, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions readthedocs/doc_builder/python_environments.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -355,6 +355,7 @@ def setup_base(self):
'conda',
'env',
'create',
'--quiet',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we don't want --quiet here. It made sense the first time I read the docs, but @jorisvandenbossche made me realized that it does not show all the packages installed either (only when called with conda env). More discussion here #5099 (comment)

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that without --quiet, it also does not show all the packages installed. It only shows the download progress output. In some way you can derive from that the installed packages, but only for short package names (otherwise the name and certainly the version is truncated), and it is also in a very unreadable way (compared to conda list or the way conda create lists the packages to be installed).
So given that, I would personally still be in favor of using --quiet here, as it simply removes somewhat non-useful output.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See eg the output of the conda env create step in https://readthedocs.org/projects/geopandas/builds/8384815/: for quite some of the packages in the download progress, you can't see the full version, and for some not even the full package name.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right!

So, merging this since it's the right direction to go. I'd love a contribution of #5099 soon, so we complete this output :)

'--name',
self.version.slug,
'--file',
Expand Down Expand Up @@ -386,6 +387,7 @@ def install_core_requirements(self):
'conda',
'install',
'--yes',
'--quiet',
'--name',
self.version.slug,
]
Expand Down