-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove view docs dropdown #5400
Conversation
This removes it from the: * User profile page * Homepage This caused a significant DB load when a project has a large number of versions, and is almost certainly never used by users. They can click the project to get a specific version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we need to address here, but we should return to this and potentially remove the link to the build list page when a project doesn't have a build. This seems like a strange place to send a user that is on a profile page -- like, they probably don't have the rights to build the project anyways, so way are we pointing users there?
It matches the current implementation, so this is fine for now.
<a href="{{ project.get_docs_url }}">{% trans "View Docs" %} | ||
{% else %} | ||
<a href="{{ project.get_builds_url }}">{% trans "No Docs" %}</a> | ||
{% endif %} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: else
and endif
indentation is wrong.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually it was missing a </a>
:/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
What would be the solution here? Removing the "No docs" button completely and only show "View docs" when there is docs to show? |
I guess we can address that in the site redesign |
I'll continue @ericholscher's work here
It looks like this