Remove old/deprecated build endpoints #5479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
humitos
force-pushed
the
humitos/remove-deprecated-webhooks
branch
from
176542f to
779cf7b
Compare
stsewd
reviewed
Mar 18, 2019
| def _allow_deprecated_webhook(project): | ||
| return project.has_feature(Feature.ALLOW_DEPRECATED_WEBHOOKS) | ||
|
|
||
|
|
||
| def _build_version(project, slug, already_built=()): |
There was a problem hiding this comment.
We can move this to another file later I guess
|
This is another place where I'd like to do a "brown out" before we remove the code completely, so users can yell if we break too much. Let's do an |
humitos
force-pushed
the
humitos/remove-deprecated-webhooks
branch
from
779cf7b to
3c1c5ba
Compare
|
I updated the PR to resolve the conflicts. The PR that return an error at NGINX level was deployed 7 days ago and it's properly returning |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We already communicated this to users in different opportunities when we GitHub deprecated GitHub Services. I think it's safe to finally remove them completely.
Closes #5057