Remove USE_SETUPTOOLS_LATEST feature flag #5578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stsewd
approved these changes
Apr 8, 2019
|
I'm guessing we already have some projects with this flag enabled |
|
Actually, we do have ~10k projects with this feature flag. Currently, all of our projects are building with |
|
I think we should remove it -- it was something we were going to test, but I don't think we really ever did anything real with it. |
humitos
force-pushed
the
humitos/use-latest-setuptools
branch
from
695c162 to
b69007d
Compare
humitos
changed the title
|
I removed the feature flag completely and default to |
stsewd
approved these changes
Apr 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should test that a couple of the projects with this feature in production builds locally when using setuptools==41 and we can deploy it after that I suppose.