Update get_absolute_url for External Versions #6020
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows us to properly set a new domain in production for the external version hosting. It's a bit hacky for now, mostly because we don't have a way to specify HTML or PDF versions of the external versions. We will need to think more about the UX around multiple types, but that's also an existing issue with our current doc builds (we only link to HTML).
saadmk11
approved these changes
Jul 31, 2019
There was a problem hiding this comment.
This looks good and this is what I did in the first place but I changed it because we won't be able to do this
https://docs.readthedocs.io/32/ we have to have a file name and extension https://docs.readthedocs.io/32/index.html.
if thats not an issue then I think it good enough
|
Yea, the local serving is a bit weak, but it isn't too much of a worry. We will be changing up how all this works soon, so that's why I'm trying to keep it simple. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows us to properly set a new domain in production for the external version hosting.
It's a bit hacky for now,
mostly because we don't have a way to specify HTML or PDF versions of the external versions.
We will need to think more about the UX around multiple types,
but that's also an existing issue with our current doc builds (we only link to HTML).