Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sort versions taking into consideration the vcs type #6049

Merged
merged 4 commits into from
Aug 8, 2019
Merged

Sort versions taking into consideration the vcs type #6049

merged 4 commits into from
Aug 8, 2019

Conversation

stsewd
Copy link
Member

@stsewd stsewd commented Aug 8, 2019

@stsewd stsewd requested review from davidfischer and a team August 8, 2019 05:59
stsewd
stsewd commented Aug 8, 2019
View reviewed changes
readthedocs/rtd_tests/tests/projects/test_version_sorting.py
)

def test_sort_svn_trunk(self):
identifiers = ['/trunk/', '1.0', '2.0', '1.1', '1.9', '1.10']
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not really sure about this one, but it's as fallback_branch, so 🤷‍♂️

and not like we have many of these 👀

@stsewd stsewd mentioned this pull request Aug 8, 2019
Closed
ericholscher
ericholscher approved these changes Aug 8, 2019
View reviewed changes
Copy link
Member

@ericholscher ericholscher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense.

readthedocs/rtd_tests/tests/projects/test_version_sorting.py Show resolved Hide resolved
davidfischer
davidfischer approved these changes Aug 8, 2019
View reviewed changes
readthedocs/projects/version_handling.py Outdated Show resolved Hide resolved
@stsewd @davidfischer
update copy
90642fa 
Co-Authored-By: David Fischer <djfische@gmail.com>
@stsewd stsewd merged commit 1e8b273 into readthedocs:master Aug 8, 2019
@stsewd stsewd deleted the sort-versions-vcs branch August 8, 2019 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidfischer davidfischer davidfischer approved these changes

@ericholscher ericholscher ericholscher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stsewd @ericholscher @davidfischer