Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use trigger_build for update_repos command #6422

Merged
merged 3 commits into from
Dec 3, 2019
Merged

Conversation

humitos
Copy link
Member

@humitos humitos commented Dec 1, 2019

Use trigger_build (that will use Celery if enabled) when importing a Project (import_project_from_live) or updating documentation (update_repos) via manage commands.

Use `trigger_build` (that will use Celery if enabled) when importing a
Project (import_project_from_live) or updating
documentation (update_repos) via manage commands.
@humitos humitos requested a review from stsewd December 1, 2019 15:08
version.pk,
force=force,
)
else:
Copy link
Member

@stsewd stsewd Dec 3, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This else shouldn't be deleted.

Copy link
Member

@stsewd stsewd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't find any reason to not use trigger_build 👍 . I cleaned up the imports and fix a missing else to keep the same logic. Also, I realized that we are not handling correctly INTERNAL/EXTERNAL. I'm creating a good first issue for that.

@stsewd
Copy link
Member

stsewd commented Dec 3, 2019

#6427

@humitos
Copy link
Member Author

humitos commented Dec 3, 2019

Thanks for the review and the fixes!

@humitos humitos merged commit 7ad669a into master Dec 3, 2019
@humitos humitos deleted the humitos/update-repos-task branch December 3, 2019 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants