Enable content security policy in report-only mode #6642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- If CSP were not in report-only mode, this would prevent * framing the site (already prevented with x-frame-options) * embedding any applets, objects, or embeds * block any mixed content - Instead violations of these policies will be reported. They can be reported to Sentry if CSP_REPORT_URI is configured
davidfischer
deleted the
davidfischer/content-security-policy-reporting
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Content security policy is a security measure that sites can opt into by sending a configurable HTTP header. When a site is really locked down, this can prevent most XSS attacks by restricting inline JS completely or restricting the origins where scripts may be loaded from or send data to.
Getting there will be hard and this is just a very first step in that process. This change:
CSP_REPORT_URIis configured (the reporting is done by the browser, not some task in our code).This change can create a feedback loop where we can slowly add policies, fix any issues we see from those policies reported to Sentry from production, and then ensure there's no fallout from those policies. When we are happy with our settings, we can switch from report-only to actually enforce the policy.
Ref #2793