New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Figure out the host IP when using Docker #6707

Merged

davidfischer merged 2 commits into master from davidfischer/docker-figure-out-hostip

Feb 26, 2020

Contributor

davidfischer commented Feb 25, 2020

Only do this when it isn't specified
While host.docker.internal does resolve on a Mac, this isn't helpful because platform.system() == 'Linux' when inside docker on a Mac.


          Figure out the host IP when using Docker

8e07a23

- Only do this when it isn't specified

davidfischer requested review from humitos and a team

February 25, 2020 20:09


          Fix a typo

b651eee

ericholscher approved these changes

View reviewed changes

davidfischer merged commit ef29235 into master

davidfischer deleted the davidfischer/docker-figure-out-hostip branch

February 26, 2020 16:57

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet