Use storage.open API correctly for tar files (build cached envs) #6799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of downloading the file into a temporary file (`storage.open` and then `.read`) to save the file into another temporary file (our loop reading by chunks) we just use the `storage.open` response as the input of the `tarfile.open` function and extract it from there.
stsewd
approved these changes
Mar 23, 2020
|
Merging. Failing tests are unrelated to this PR (master seems broken as well) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of downloading the file into a temporary file (
storage.openand then
.read) to save the file into another temporary file (ourloop reading by chunks) we just use the
storage.openresponse as theinput of the
tarfile.openfunction and extract it from there.Related to #6793