Add CloudFlare Cache tags support #6887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This lets us purge the CDN more easily. This requires a version in the files_changed signal.
davidfischer
approved these changes
Apr 9, 2020
There was a problem hiding this comment.
Looks good and signaling purging seems like a great idea.
Here's the Cloudflare docs on cache-tags: https://support.cloudflare.com/hc/en-us/articles/200169246-Purging-cached-resources-from-Cloudflare
humitos
approved these changes
Apr 9, 2020
Comment on lines
+129
to
+130
| # Include the project & project-version so we can do larger purges if needed | ||
| response['Cache-Tags'] = f'{final_project.slug}-{version_slug},{final_project.slug}' |
There was a problem hiding this comment.
With this, we can decide to purge "project & version" or the whole "project" (all versions)? That's why we are separating this by a comma?
There was a problem hiding this comment.
That's correct. In the docs I linked above, cache tags are comma separated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This lets us purge the CDN more easily.
This requires a version in the files_changed signal.