-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix URLs like /projects/subproject
from 404ing when they don't end with a slash
#6888
Conversation
…with a slash This was hit by users. You can test it here: https://docs.celeryproject.org/projects/kombu
Looks good locally:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Edit: once the CI is fixed up.
We also have an issue with single-single subprojects, eg |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. I want to understand one the cases added, only.
Test are not passing for some reason as well.
Ah, we need to update the matching of the URLs because there is a new attribute now. |
Weird... our own build on RTD failed because of timeout. Is our project already that big? |
This was hit by users.
You can test it here: https://docs.celeryproject.org/projects/kombu