Remove broadcast function #7044
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't need this anymore
|
Also, not sure about the remove_dirs function, but I can try removing it where we can in another PR |
ericholscher
reviewed
May 7, 2020
|
@stsewd what is this blocked on? |
|
@ericholscher just want to be sure we remove calls to this function from other repos first (ext and .com) |
ericholscher
added a commit
that referenced
this pull request
May 12, 2020
This was removed in #7044, and it's needed to properly link to the PR builds and update their status.
ericholscher
added a commit
that referenced
this pull request
May 12, 2020
This was removed in #7044, and it's needed to properly link to the PR builds and update their status.
ericholscher
added a commit
that referenced
this pull request
May 12, 2020
This was removed in #7044, and it's needed to properly link to the PR builds and update their status.
|
Only |
humitos
approved these changes
Mar 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't need this anymore
Closes #6775