Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Builders: little refactor #7500

Merged
merged 2 commits into from
Sep 22, 2020
Merged

Builders: little refactor #7500

merged 2 commits into from
Sep 22, 2020

Conversation

stsewd
Copy link
Member

@stsewd stsewd commented Sep 21, 2020

There are a lot of places where we are using checkout_path to refer to the cwd of the project, declare this at the base class instead of duplicating it everywhere.

@stsewd stsewd requested a review from a team September 22, 2020 00:06
humitos
humitos approved these changes Sep 22, 2020
View reviewed changes
Copy link
Member

@humitos humitos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the refactor. However, I'd rename self.cwd to self.project_path that makes it more explicit where it points to.

readthedocs/doc_builder/base.py Outdated Show resolved Hide resolved
readthedocs/doc_builder/base.py Outdated Show resolved Hide resolved
@stsewd stsewd merged commit b74fe8d into master Sep 22, 2020
@stsewd stsewd deleted the refactor-builders branch September 22, 2020 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@humitos humitos humitos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stsewd @humitos