Add feature flag to not install the latest version of pip #7522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just in case the new version of pip breaks too many projects, we can downgrade easily.
humitos
reviewed
Oct 1, 2020
| @@ -1581,6 +1581,7 @@ def add_features(sender, **kwargs): | |||
| INDEX_FROM_HTML_FILES = 'index_from_html_files' | |||
| DONT_CREATE_INDEX = 'dont_create_index' | |||
| USE_NEW_PIP_RESOLVER = 'use_new_pip_resolver' | |||
| DONT_INSTALL_LATEST_PIP = 'dont_install_latest_pip' | |||
There was a problem hiding this comment.
Instead of _LATEST in the name, I'd use one that communicates the resolver. Like, DONT_USE_NEW_PIP_RESOLVER that follow the same pattern than the above feature flag.
There was a problem hiding this comment.
This is so we can re-use this in the future
There was a problem hiding this comment.
Makes sense to me. I know this code will eventually be stale, but the name isn't a huge issue, and the comment in the code makes it clear for now at least.
ericholscher
approved these changes
Oct 26, 2020
| @@ -1581,6 +1581,7 @@ def add_features(sender, **kwargs): | |||
| INDEX_FROM_HTML_FILES = 'index_from_html_files' | |||
| DONT_CREATE_INDEX = 'dont_create_index' | |||
| USE_NEW_PIP_RESOLVER = 'use_new_pip_resolver' | |||
| DONT_INSTALL_LATEST_PIP = 'dont_install_latest_pip' | |||
There was a problem hiding this comment.
Makes sense to me. I know this code will eventually be stale, but the name isn't a huge issue, and the comment in the code makes it clear for now at least.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just in case the new version of pip breaks too many projects,
we can downgrade easily.