Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Search: filter only active and built versions from subprojects #7723

Merged
merged 2 commits into from
Dec 2, 2020
Merged

Search: filter only active and built versions from subprojects #7723

merged 2 commits into from
Dec 2, 2020

Conversation

stsewd
Copy link
Member

@stsewd stsewd commented Dec 2, 2020

This wasn't causing any problems in production because we already filter by active versions only, but better be safe.

@stsewd stsewd requested a review from a team December 2, 2020 15:43
ericholscher
ericholscher approved these changes Dec 2, 2020
View reviewed changes
Copy link
Member

@ericholscher ericholscher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar comment on whether hidden actually means "don't show in subproject search results".

@stsewd
Copy link
Member Author

stsewd commented Dec 2, 2020

Just linking to the same part of the docs https://docs.readthedocs.io/en/stable/versions.html#hidden We don't show hidden versions in superprojects results.

@stsewd stsewd merged commit 8118908 into master Dec 2, 2020
@stsewd stsewd deleted the fix-subprojects-search branch December 2, 2020 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericholscher ericholscher ericholscher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stsewd @ericholscher