Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use "path_with_namespace" for GitLab RemoteRepository full_name Field #7746

Conversation

saadmk11
Copy link
Member

For GitLab we use
repo.full_name = fields['name_with_namespace'] # ("Maksudul Haque / test")
for full_name and not
repo.full_name = fields['path_with_namespace'] # ("saadmk11/test")
Here fields['path_with_namespace'] is more appropriate for the full_name field as it looks similar to the other VCS providers (GitHub, BitBucket) full_name field value.

@saadmk11 saadmk11 requested a review from humitos December 10, 2020 17:50
@saadmk11 saadmk11 changed the title Gitlab repo full name Use "path_with_namespace" for GitLab RemoteRepository full_name Field Dec 10, 2020
Copy link
Member

@humitos humitos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent!

@humitos humitos merged commit 018dc6b into readthedocs:remote-repository-normalization Dec 14, 2020
@saadmk11 saadmk11 deleted the gitlab_repo_full_name branch December 14, 2020 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants