-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't require npm to build from source #1039
Conversation
We already have this scripts in package.json, and we commit the static files in the repo. Close #1014
780018c
to
f0fc03f
Compare
This also closes #1014 |
Looks like warnings are shown when running more info at pypa/pip#2933 (comment) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, to show that this works, you can try searching the docs with the PR build and Latest
For clarification, what we have decided to do here is to communicate deprecation of installation via Git for now, and separate the build step. It seems like the issue in #1037 is that projects are installing through Git -- an installation channel we don't want to support. We don't want to support this as rebuilding assets makes PRs conflict, and we're tied to making release decisions that also include people install unpinned versions of our theme. For now, the build assets step will be moved, but this PR will be partially reverted later. We'll move back to removing static assets checked into this repository, and all builds should go through an official release. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a temporary fix, we need to next figure out deprecation plans.
This reverts commit c40686d. This commit and the subsequent one broke the search bar on our hosted documentation. Signed-off-by: Paul Chaignon <paul@cilium.io>
This reverts commit c40686d. This commit and the subsequent one broke the search bar on our hosted documentation. Signed-off-by: Paul Chaignon <paul@cilium.io>
We already have this scripts in package.json,
and we commit the static files in the repo.
Close #1037