Show version for Sphinx and this template in footer.

[marxin]

Emits now:

[marxin]

MIT8

Can you please explain this? Is the community interested in the change, or should I close the pull request?

[benjaoming]

@marxin I've really been wanting this, too 🎉

We have some issue with legacy installation setups, though. So if we introduced it as is, it would unfortunately give the same errors as described here:

#1355

@agjohnson moving forwards, we should probably put something on the roadmap about making legacy setups unsupported and find a way to detect them and fail nicely? On of the steps needed is also unfortunately on readthedocs.org - readthedocs/readthedocs.org#9654

[marxin]

Please make a similar PR if you want the feature in the future. This PR conflicts, thus I'm closing it.

[benjaoming]

@marxin I was going over #1355 and recalled that it only failed because an undefined context variable was used in a way that it cannot.

If you implement it in a way that anticipates that rtd_theme_version may be None then it can work. For instance {%- if rtd_theme_version -%}(v{{ rtd_theme_version }}){%- endif -%}

Btw that "MIT8" comment is bot spam that we're unfortunately seeing a lot of on GitHub nowadays.

[marxin]

If you implement it in a way that anticipates that rtd_theme_version may be None then it can work. For instance {%- if rtd_theme_version -%}(v{{ rtd_theme_version }}){%- endif -%}

The question is: How can it be None if I set it in:
app.connect("html-page-context", update_context)
?

[benjaoming]

That's the longer story that is uncovered in #1355 and readthedocs/readthedocs.org#9654

Basically, you cannot rely on app.connect to be executed in two cases:

• Legacy configurations that didn't add the theme the correct way
• On RTD sphinx_rtd_theme has to be added to extensions in conf.py which is both unnecessary and unconventional (due to an injection that RTD does, which is probably also related to legacy)

We are facing the same issue with the automatic enabling of sphinxcontrib-jquery which adds some priority to fixing the issue.

[marxin]

Sure, I've just made a new PR in #1410.