Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Populate html_context with READTHEDOCS_* environment variables #1581

Merged
merged 2 commits into from
Aug 1, 2024
Merged

Populate html_context with READTHEDOCS_* environment variables #1581

merged 2 commits into from
Aug 1, 2024

Conversation

humitos
Copy link
Member

@humitos humitos commented Jul 31, 2024 •
edited
Loading

@humitos humitos requested a review from a team as a code owner July 31, 2024 14:57
@humitos humitos force-pushed the humitos/populate-environment-variables branch from bad5c2a to 6708c9a Compare July 31, 2024 15:00
@humitos humitos mentioned this pull request Jul 31, 2024
Merged
@humitos
Copy link
Member Author

humitos commented Jul 31, 2024

I put this on 3.0, but it could definitely go into the 2.x series, tho. We haven't done the final release for our rc1 yet.

agjohnson
agjohnson approved these changes Jul 31, 2024
View reviewed changes
Copy link
Collaborator

@agjohnson agjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have a preference whether this is in the 2 or 3 series release, but maybe it does make sense in 2, in case there is any reason why users can't use the 3 series release, or don't upgrade for any reason?

@humitos
Copy link
Member Author

humitos commented Aug 1, 2024

but maybe it does make sense in 2

Cool, I will fix the tests and do a 2.1.0rc2 in the following days.

@humitos
Copy link
Member Author

humitos commented Aug 1, 2024

I'm expecting the tests for Sphinx 8.x to fail because we don't support it yet.

@humitos humitos merged commit cf898d3 into master Aug 1, 2024
7 of 8 checks passed
@humitos humitos deleted the humitos/populate-environment-variables branch August 1, 2024 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agjohnson agjohnson agjohnson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Read READTHEDOCS_PROJECT from environment variables
2 participants
@humitos @agjohnson