Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: update the installation note #1595

Merged
merged 2 commits into from
Aug 20, 2024
Merged

Docs: update the installation note #1595

merged 2 commits into from
Aug 20, 2024

Conversation

humitos
Copy link
Member

@humitos humitos commented Aug 19, 2024 •
edited by agjohnson
Loading

Translated string work with/without the theme added into the extensions. However, it's still required to be inside the extensions because of sphinxcontrib-jquery.

I'm keeping the note, but changing it content.

@humitos
Docs: update the installation note
6b0d942 
Translated string work with/without the theme added into the ``extensions``.
However, it's still required to be inside the extensions because of
``sphinxcontrib-jquery``.

I'm keeping the note, but changing it content.
@humitos humitos requested a review from a team as a code owner August 19, 2024 14:49
@humitos humitos mentioned this pull request Aug 19, 2024
Merged
agjohnson
agjohnson approved these changes Aug 19, 2024
View reviewed changes
Copy link
Collaborator

@agjohnson agjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This matches my worries about removing the explicit extensions configuration. I'm guessing there is some way around this behavior, and perhaps it's load order, but the jquery extension specifically did benefit from explicit extension configuration.

docs/installing.rst Outdated Show resolved Hide resolved
@humitos @agjohnson
Update docs/installing.rst
744d0eb 
Co-authored-by: Anthony <aj@ohess.org>
@humitos humitos merged commit 768dcc1 into master Aug 20, 2024
0 of 2 checks passed
@humitos humitos deleted the humitos/installation-note branch August 20, 2024 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agjohnson agjohnson agjohnson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@humitos @agjohnson