Don't show scrollbar if there's nothing to scroll #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix readthedocs#200 Only tested with Firebug, didn't bother to install SASS.
|
cc @agjohnson |
|
BTW this works with Chromium and Firefox on Linux. |
|
Thanks for submitting a patch! Unfortunately this isn't a full fix. As |
|
I thought displaying a vertical scrollbar is actually desired when the content overflows.
|
|
Ah okay -- no, that's a display bug new to 0.18. it should be hidden completely. |
|
How else would you display larger menus then? |
|
It should display as-is, but with a hidden scrollbar that still allows for scrolling. The current CSS works correctly rather sporadically across browsers, and not at all on several browsers on Linux it seems. |
|
I don't understand what you mean with a hidden scrollbar. Should it only show when the user hovers? Or should it scroll with the rest of the site? On 6 June 2015 23:48:30 CEST, Anthony notifications@github.com wrote:
|
|
The scrollbar should never show. |
agjohnson
added a commit
to agjohnson/sphinx_rtd_theme
that referenced
this pull request
Jul 17, 2015
This resolves readthedocs#200, where a scrollbar was sometimes visible on the navbar. This unfortunately wasn't addressable with just CSS, as outlined in readthedocs#206. Because we need the element to be scrollable, we can't set `overflow: hidden` on the nav element. This fixes this issue by: * Adding a `wy-side-scroll` element over the fixed position nav element and under the menu item elements * `wy-side-scroll` is set to 320px width, while the fixed position nav elements and menu item elements are 300px, clipping the scrollbar with `overflow-x: hidden` on the fixed position element * Javascript is set to scroll the new scroll element instead of the parent fixed position element * For backwards compatibility on already generated HTML, the new scroll element is added dynamically if it is missing, and children of the fixed position element are moved there. This was tested to be working in both cases, on Linux FF, Chrome, Windows IE, and OSX Chrome and Safari.
agjohnson
added a commit
to agjohnson/sphinx_rtd_theme
that referenced
this pull request
Jul 17, 2015
This resolves readthedocs#200, where a scrollbar was sometimes visible on the navbar. This unfortunately wasn't addressable with just CSS, as outlined in readthedocs#206. Because we need the element to be scrollable, we can't set `overflow: hidden` on the nav element. This fixes this issue by: * Adding a `wy-side-scroll` element over the fixed position nav element and under the menu item elements * `wy-side-scroll` is set to 320px width, while the fixed position nav elements and menu item elements are 300px, clipping the scrollbar with `overflow-x: hidden` on the fixed position element * Javascript is set to scroll the new scroll element instead of the parent fixed position element * For backwards compatibility on already generated HTML, the new scroll element is added dynamically if it is missing, and children of the fixed position element are moved there. This was tested to be working in both cases on a variety of platforms: Linux FF, Chrome, Windows IE, OSX Chrome and Safari, iPhone 5.1, and Android 4.2.
agjohnson
added a commit
to agjohnson/sphinx_rtd_theme
that referenced
this pull request
Sep 9, 2015
This resolves readthedocs#200, where a scrollbar was sometimes visible on the navbar. This unfortunately wasn't addressable with just CSS, as outlined in readthedocs#206. Because we need the element to be scrollable, we can't set `overflow: hidden` on the nav element. This fixes this issue by: * Adding a `wy-side-scroll` element over the fixed position nav element and under the menu item elements * `wy-side-scroll` is set to 320px width, while the fixed position nav elements and menu item elements are 300px, clipping the scrollbar with `overflow-x: hidden` on the fixed position element * Javascript is set to scroll the new scroll element instead of the parent fixed position element This was tested to be working in both cases on a variety of platforms: Linux FF, Chrome, Windows IE, OSX Chrome and Safari, iPhone 5.1, and Android 4.2.
agjohnson
added a commit
to agjohnson/sphinx_rtd_theme
that referenced
this pull request
Sep 9, 2015
This resolves readthedocs#200, where a scrollbar was sometimes visible on the navbar. This unfortunately wasn't addressable with just CSS, as outlined in readthedocs#206. Because we need the element to be scrollable, we can't set `overflow: hidden` on the nav element. This fixes this issue by: * Adding a `wy-side-scroll` element over the fixed position nav element and under the menu item elements * `wy-side-scroll` is set to 320px width, while the fixed position nav elements and menu item elements are 300px, clipping the scrollbar with `overflow-x: hidden` on the fixed position element * Javascript is set to scroll the new scroll element instead of the parent fixed position element This was tested to be working in both cases on a variety of platforms: Linux FF, Chrome, Windows IE, OSX Chrome and Safari, iPhone 5.1, and Android 4.2.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #200
Only tested with Firebug, didn't bother to install SASS.