Style headerlinks for table captions properly #454
Conversation
There was a problem hiding this comment.
Looks good to me. @agjohnson @ericholscher Would be nice to get more then one approval before committing.
|
Ping? |
|
I am doing a dev sprint this weekend will take a look then. |
|
Great, thanks. Please also look at #432 if possible. |
|
The changes are ok but not perfect, when you hover over the text it shift to the left. Can you try to fix this? |
|
@Blendify Please test the latest version. |
|
Ping? |
|
Looks like a reasonable change, is there a good example (gif?) of the new change. |
|
I will look at current PRs this weekend |
|
Here is a screenshot of what changed. Before: After: Previously the ¶ symbol was always visible, now it is only visible on hover. @benjaoming #432 already has a screenshot, see #432 (comment). |
sass/_theme_rst.sass
Outdated
| &:hover .headerlink | ||
| display: inline-block | ||
| &:hover .headerlink:after | ||
| visibility: visible | ||
|
|
There was a problem hiding this comment.
LGTM, although I think slightly reducing the link for table captions looks nicer, by adding:
table > caption .headerlink:after
font-size: 12pxCurrent PR:
With font-size: 12px:
* Style headerlinks for table captions properly Fixes readthedocs#437 * Make .headerlink code work with center-aligned elements * Lowered font size for table headerlink as requested in the review
Fixes #437.
Now headerlinks for tables behave the same way like for headers: invisible by default, showing on hover, using Font Awesome.