build: Add rubocop to CI #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethowitz
force-pushed
the
add-ci
branch
3 times, most recently
from
7a53628 to
1f3d3b3
Compare
Adds a rubocop action to our CI pipeline, installs the Airbnb rubocop gem, and fixes all of the resulting rubocop errors. The new CI action tests with ruby versions 2.7, 3.0, 3.1, and 3.2. This commit also changes the .ruby-version to 3.2.1. We intend to support all of the major ruby versions >= 2.7, but for development purposes, it is easiest to work with the most modern version because the developer tooling is more robust and more frequently updated.
ethan-readyset
commented
Nov 3, 2023
|
|
||
| Style/StringLiterals: | ||
| EnforcedStyle: single_quotes |
There was a problem hiding this comment.
This is opinionated of me 😁 But happy to discuss!
Merged
helpotters
approved these changes
Nov 7, 2023
helpotters
added a commit
that referenced
this pull request
Nov 7, 2023
This reverts commit 6c779a1.
helpotters
added a commit
that referenced
this pull request
Nov 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a rubocop action to our CI pipeline, installs the Airbnb rubocop
gem, and fixes all of the resulting rubocop errors. The new CI action
tests with ruby versions 2.7, 3.0, 3.1, and 3.2.
This commit also changes the .ruby-version to 3.2.1. We intend to
support all of the major ruby versions >= 2.7, but for development
purposes, it is easiest to work with the most modern version because the
developer tooling is more robust and more frequently updated.