routing: Add Readyset.route
#47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethowitz
force-pushed
the
add-route-and-exclude
branch
from
365a809 to
6be2525
Compare
ethowitz
force-pushed
the
remove-resolver
branch
2 times, most recently
from
fdf7bd5 to
ade0285
Compare
ethowitz
force-pushed
the
add-route-and-exclude
branch
from
6be2525 to
a1ab38c
Compare
Our approach to routing queries requires more granularity than is provided by the ActiveRecord middleware, so this commit removes the code that integrates with that middleware.
ethowitz
force-pushed
the
remove-resolver
branch
from
ade0285 to
7779fdb
Compare
Adds a `Readyset.route` method, which takes a block and routes to ReadySet all the queries that occur within that block.
ethowitz
force-pushed
the
add-route-and-exclude
branch
from
a1ab38c to
40433b0
Compare
|
Sorry, I didn't notice the dependency on PR #41. Reverted for now. |
helpotters
reviewed
Dec 12, 2023
Closed
|
@helpotters Fixed the |
helpotters
approved these changes
Dec 13, 2023
|
Merging after #46 |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 13, 2023
Reopening as it doesn't look like this was merged properly. Contains the same changes that were in #47, but this time, the base branch is `main`
helpotters
pushed a commit
that referenced
this pull request
Dec 15, 2023
Reopening as it doesn't look like this was merged properly. Contains the same changes that were in #47, but this time, the base branch is `main`
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 15, 2023
…y` syntax (#48) This commit adds an extension to `ActiveRecord::Base` that defines a `readyset_query` class method. This class method provides an easy interface for users to define named queries within the context of their models such that the queries will be routed to ReadySet. NOTE: This PR is stacked on top of #47 and should only be merged after that PR is merged Closes #3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a
Readyset.routemethod, which takes a block and routes toReadySet all the queries that occur within that block.
NOTE: This PR is stacked on top of #46 and must be merged after that is merged