Skip to content

Commit

Permalink
buildkite: Upgrade docker and docker-compose plugins
Browse files Browse the repository at this point in the history
Upgrading to 5+ versions of these plugins.  Also, pulling the version
numbers out into variables for easier updating.

Some jobs (including nextest runs) may benefit from having "tty: true"
so that they still produce colorized output.

Change-Id: I5444d12633533a7004d356dc018effa721ae4a5d
  • Loading branch information
ronh-rs committed Jan 10, 2025
1 parent b9f6be6 commit 3a9fa3e
Showing 1 changed file with 9 additions and 6 deletions.
15 changes: 9 additions & 6 deletions .buildkite/pipeline.public-common.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@ common_values:

env:
ECR_PLUGIN_VERSION: "v2.9.0"
DOCKER_PLUGIN_VERSION: "v5.12.0"
DOCKER_COMPOSE_PLUGIN_VERSION: "v5.5.0"

steps:

Expand All @@ -23,7 +25,7 @@ steps:
depends_on:
- build-image
plugins:
- docker#v3.8.0:
- docker#${DOCKER_PLUGIN_VERSION}:
image: '305232526136.dkr.ecr.us-east-2.amazonaws.com/readyset-build:${BUILDKITE_COMMIT}'
volumes:
- 'target:/workdir/target'
Expand All @@ -45,7 +47,7 @@ steps:
depends_on:
- cargo-deny-image
plugins:
- docker#v3.8.0:
- docker#${DOCKER_PLUGIN_VERSION}:
image: '305232526136.dkr.ecr.us-east-2.amazonaws.com/cargo-deny:${BUILDKITE_COMMIT}'
environment:
- SCCACHE_BUCKET=readysettech-build-sccache-us-east-2
Expand All @@ -66,7 +68,7 @@ steps:
depends_on:
- build-image
plugins:
- docker#v3.8.0:
- docker#${DOCKER_PLUGIN_VERSION}:
image: '305232526136.dkr.ecr.us-east-2.amazonaws.com/readyset-build:${BUILDKITE_COMMIT}'
volumes:
- 'target:/workdir/target'
Expand All @@ -90,8 +92,9 @@ steps:
depends_on:
- build-image
plugins:
- docker-compose#v3.7.0:
- docker-compose#${DOCKER_COMPOSE_PLUGIN_VERSION}:
run: app
tty: true
env:
- BUILDKITE_PARALLEL_JOB
- SCCACHE_BUCKET=readysettech-build-sccache-us-east-2
Expand Down Expand Up @@ -128,7 +131,7 @@ steps:
depends_on:
- build-image
plugins:
- docker-compose#v3.7.0:
- docker-compose#${DOCKER_COMPOSE_PLUGIN_VERSION}:
run: app
env:
- SCCACHE_BUCKET=readysettech-build-sccache-us-east-2
Expand Down Expand Up @@ -156,7 +159,7 @@ steps:
depends_on:
- build-image
plugins:
- docker-compose#v3.7.0:
- docker-compose#${DOCKER_COMPOSE_PLUGIN_VERSION}:
image: '305232526136.dkr.ecr.us-east-2.amazonaws.com/readyset-build:${BUILDKITE_COMMIT}'
run: app
environment:
Expand Down

0 comments on commit 3a9fa3e

Please sign in to comment.