Support Static Linking #1261
Merged
Support Static Linking #1261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…capsulate dlsym lookups. Separate object and function pointers and correctly deal generic versions of each. Remove multiple instances of warning ignores for -Wpendantic.
mjpt777
reviewed
Nov 26, 2021
|
I've added a unit test and switched over to specifying a table length instead of relying on a NULL terminator. It will still early exit on NULL fields in the table. |
tmontgomery
reviewed
Dec 23, 2021
tmontgomery
reviewed
Dec 23, 2021
tmontgomery
reviewed
Dec 23, 2021
…ed length check function. Use typedef for generic function pointer.
mjpt777
reviewed
Jan 6, 2022
| @@ -282,6 +283,19 @@ aeron_idle_strategy_t aeron_idle_strategy_backoff = | |||
| aeron_idle_strategy_backoff_state_init_args | |||
| }; | |||
|
|
|||
| static const aeron_symbol_table_obj_t aeron_idle_strategy_table[] = | |||
| { | |||
| { "sleeping", "aeron_idle_strategy_sleeping", &aeron_idle_strategy_sleeping }, | |||
There was a problem hiding this comment.
Name should be sleep rather than sleeping to have consistent naming.
There was a problem hiding this comment.
I agree, but I'd like to make that a separate change to this PR. The current PR preserves behaviour: https://github.com/real-logic/aeron/blob/master/aeron-client/src/main/c/aeron_agent.c#L301. I think it also requires a "sleep-ms" to be consistent with the Java driver as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add aeron_symbol_table and use it to resovle internal symbols.
Encapsulate dlsym lookups.
Separate object and function pointers and correctly deal generic versions of each.
Remove multiple instances of warning ignores for -Wpendantic.