Improve handling of compilation flags with CMake #572
Commits on Dec 12, 2018
-
[C++] Use PROJECT_SOURCE_DIR for sourced exceptions.
While CMAKE_SOURCE_DIR can point to another project root if Aeron is included as a subdirectory, PROJECT_SOURCE_DIR always points to Aeron's project root which will result in the same paths being generated regardless of a standalone build or subproject build.
-
[C++] Increment minimum required version of CMake to 3.1.3.
This version is the minimum required for the variable CMAKE_CXX_STANDARD.
-
[C++] Set C standard with CMake.
This adds the flag -std=c11 to GCC and Clang. Visual Studio does not seem to have full conformance to C11 standard yet.
-
[C++] Disable C and C++ extensions through CMake.
This is equal to setting -std=c11 and -std=c++11 as opposed to -std=gnu11 and -std=gnu++11.
-
[C++] Remove explicit appending of version flags.
CMake automatically appends these when it detects CMAKE_C_STANDARD and CMAKE_CXX_STANDARD has been set.
-
[C++] Remove explicit appending of
-gflag.This flag is automatically appended by CMake in debug builds which include RelWithDebInfo. Release mode should not have debug symbols.
-
[C++] Remove explicit setting of O0 for debug mode.
This flag is added automatically by CMake in Debug mode.
-
[C++] Use add_compile_options wherever possible.
add_compile_options works on both C and C++ sources and has a cleaner usage less prone to wiping off old flags.
-
[C++] Use add_compile_options for compiler flags.
add_definitions is semantically used to pass macro definitions to source files.
-
[C++] Add option to enable Ofast in release builds.
CMake automatically adds -O3 for release builds. Ofast adds potentially breaking non-standard optimizations during compilation. This change keeps -Ofast enabled for stand alone builds but disables it when Aeron is added with add_subdirectory command.
-
[C++] Pass C and C++ compilers to subprojects.
If a compiler set different from CC and CXX is used to build Aeron and tests and benchmarks are enabled by using CMAKE_C_COMPILER and CMAKE_CXX_COMPILER, Aeron source and the tests are built using different compilers.
-
[C++] Remove conditional addition of -m64 flag
x86 or x86_64 compilation is already based on the architecture of the machine running the build. These flags are necessary if the target architecture is different from the one that compiles the code.
-
[C++] Remove explicit addition of -fexceptions
fexceptions is enabled for C++ by default.
