[C] Fixes for Windows - Take 2 #794
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These functions are expected to return a value between 0 and 1 but were returning a value between 0 and RAND_MAX. RAND_MAX + 1 is known not to overflow on MSVC.
The callback does not have the correct signature which is expected by the InitOnceExecuteOnce function.
CMake v3.13 no longer includes the /FC option which makes __FILE__ lower case and absolute. This adjusts the unit test.test See https://gitlab.kitware.com/cmake/cmake/issues/18261
|
Thanks! Will merge after checks done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the same as #789 (which got reverted) but with two commits removed. It fixes the build and unit tests on Windows.
I'll implement changes discussed here (
DllMain) as a separate PR, as I feel the implementation may require more discussion, so it won't be cluttered by these changes.