Add hook to handle EC_RigidBody boxes using Physijs #41
Conversation
Add hook to handle EC_RigidBody boxes using Physijs
| console.log("ok, have cube"); | ||
| var boxSize = component.size; | ||
| if (!(boxSize.x && boxSize.y && boxSize.z)) | ||
| console.log("RigidBody of entitity " + entity.id + ": one or more dimensions are zero"); |
There was a problem hiding this comment.
just noticed a typo in the log message, i've written this sometimes too :) "entitity"
|
does this mean that visible mesh debug boxes are now always created for entities with rigidbodies? i don't see what would make this code optional here. also, i wonder if the centralised way to register component handlers proposed in issue #35 would be good for this. it is there already in scene for the data part, but not for view. needing this pattern all over seems weak? Application.prototype.onRigidBodyPossiblyAdded = function(entity, component) { when we already have nice registerComponent and createComponent in WebTundra/src/scene/Component.js Line 172 in 28fef4d (i copy that note also to the correct issue to have that talk in the right place) |
No description provided.