Build thread count #738
Build thread count #738
Conversation
Set BUILD_THREADS to the required count. %NUMBER_OF_PROCESSORS% by default.
| @@ -55,6 +55,9 @@ IF NOT EXIST "%DEPS%". mkdir "%DEPS%" | |||
| :: User-defined variables | |||
| set BUILD_OPENSSL=TRUE | |||
| set USE_JOM=TRUE | |||
| :: Set to the number of build processes to use | |||
| set BUILD_THREADS=%NUMBER_OF_PROCESSORS% | |||
There was a problem hiding this comment.
You should probably only do this set if BUILD_THREADS is not defined. Right now you cant configure this outside the script by setting BUILD_THREADS before running the deps build, it will always be overwritten by num of processors on the OS. I guess this works if you want to manually go ahead and edit the script on this line.
Also I would make it TUNDRA_BUILD_THREADS as BUILD_THREADS is quite generic and probably not good to force people to add to their env variables permanently. You know if someone wants to do that.
There was a problem hiding this comment.
OK, I think in that case I probably should make the same changes to set of BUILD_OPENSSL and USE_JOM, since those cannot be set from outside the build process.
Should I prefix these alse with TUNDRA_ ?
There was a problem hiding this comment.
Yes thats a good idea if you feel up to it. Maybe even TUNDRA_DEP_X would be better as we already have TUNDRA_DEP_PATH
vorbis and protobuf projects would be incomplete due to: error MSB4018: The "ResolveVCProjectOutput" task failed unexpectedly. Workaround is to not set /m for these projects.
This patch introduces the user-defined variable BUILD_THREADS. By default this is set to %NUMBER_OF_PROCESSORS%. If you need to limit the core usage, just set it. I.e.
set BUILD_THREADS=3