Skip to content

Commit

Permalink
chore: rename OverridenSuperCallConfiguration to OverriddenSuperCallC…
Browse files Browse the repository at this point in the history
…onfiguration

BREAKING CHANGE: As `OverridenSuperCallConfiguration` is a
publicly-exposed struct, this rename should be considered breaking.
  • Loading branch information
bricker committed Nov 10, 2020
1 parent eb0c1b2 commit 629e94c
Show file tree
Hide file tree
Showing 5 changed files with 10 additions and 5 deletions.
5 changes: 5 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,11 @@
Defaults to `true`.
[Skoti](https://github.com/Skoti)

* Renamed `OverridenSuperCallConfiguration` to
`OverriddenSuperCallConfiguration`.
[Bryan Ricker](https://github.com/bricker)
[#3426](https://github.com/realm/SwiftLint/pull/3426)

#### Experimental

* None.
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import SourceKittenFramework

public struct OverriddenSuperCallRule: ConfigurationProviderRule, ASTRule, OptInRule, AutomaticTestableRule {
public var configuration = OverridenSuperCallConfiguration()
public var configuration = OverriddenSuperCallConfiguration()

public init() {}

Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
public struct OverridenSuperCallConfiguration: RuleConfiguration, Equatable {
public struct OverriddenSuperCallConfiguration: RuleConfiguration, Equatable {
private let defaultIncluded = [
//NSObject
"awakeFromNib()",
Expand Down
2 changes: 1 addition & 1 deletion Tests/LinuxMain.swift
Original file line number Diff line number Diff line change
Expand Up @@ -1356,7 +1356,7 @@ extension RuleConfigurationTests {
("testTrailingWhitespaceConfigurationApplyConfigurationSetsIgnoresComments", testTrailingWhitespaceConfigurationApplyConfigurationSetsIgnoresComments),
("testTrailingWhitespaceConfigurationCompares", testTrailingWhitespaceConfigurationCompares),
("testTrailingWhitespaceConfigurationApplyConfigurationUpdatesSeverityConfiguration", testTrailingWhitespaceConfigurationApplyConfigurationUpdatesSeverityConfiguration),
("testOverridenSuperCallConfigurationFromDictionary", testOverridenSuperCallConfigurationFromDictionary),
("testOverriddenSuperCallConfigurationFromDictionary", testOverriddenSuperCallConfigurationFromDictionary),
("testModifierOrderConfigurationFromDictionary", testModifierOrderConfigurationFromDictionary),
("testModifierOrderConfigurationThrowsOnUnrecognizedModifierGroup", testModifierOrderConfigurationThrowsOnUnrecognizedModifierGroup),
("testModifierOrderConfigurationThrowsOnNonModifiableGroup", testModifierOrderConfigurationThrowsOnNonModifiableGroup),
Expand Down
4 changes: 2 additions & 2 deletions Tests/SwiftLintFrameworkTests/RuleConfigurationTests.swift
Original file line number Diff line number Diff line change
Expand Up @@ -274,8 +274,8 @@ class RuleConfigurationTests: XCTestCase {
}
}

func testOverridenSuperCallConfigurationFromDictionary() {
var configuration = OverridenSuperCallConfiguration()
func testOverriddenSuperCallConfigurationFromDictionary() {
var configuration = OverriddenSuperCallConfiguration()
XCTAssertTrue(configuration.resolvedMethodNames.contains("viewWillAppear(_:)"))

let conf1 = ["severity": "error", "excluded": "viewWillAppear(_:)"]
Expand Down

0 comments on commit 629e94c

Please sign in to comment.