Rewrite let_var_whitespace rule with SwiftSyntax (#5367)

realm · Nov 29, 2023 · 8cb2cf9 · 8cb2cf9
1 parent ff1e966
commit 8cb2cf9
Show file tree

Hide file tree

Showing 12 changed files with 235 additions and 246 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -29,6 +29,11 @@
 * Rewrite `multiline_literal_brackets` rule using SwiftSyntax, fixing some
   false positives that would happen when comments are present.  
   [Marcelo Fabri](https://github.com/marcelofabri)
+
+* Rewrite `let_var_whitespace` rule using SwiftSyntax, fixing false positives
+  when attributes attached to declarations were spread over multiple lines.  
+  [SimplyDanny](https://github.com/SimplyDanny)
+  [#4801](https://github.com/realm/SwiftLint/pull/4801)
 
 #### Bug Fixes
 

diff --git a/Source/SwiftLintBuiltInRules/Rules/Lint/DeploymentTargetRule.swift b/Source/SwiftLintBuiltInRules/Rules/Lint/DeploymentTargetRule.swift
@@ -3,6 +3,7 @@ import SwiftSyntax
 @SwiftSyntaxRule
 struct DeploymentTargetRule {
     fileprivate typealias Version = DeploymentTargetConfiguration.Version
+
     var configuration = DeploymentTargetConfiguration()
 
     static let description = RuleDescription(

diff --git a/...e/SwiftLintBuiltInRules/Rules/RuleConfigurations/DiscouragedDirectInitConfiguration.swift b/...e/SwiftLintBuiltInRules/Rules/RuleConfigurations/DiscouragedDirectInitConfiguration.swift
@@ -1,8 +1,5 @@
 import SwiftLintCore
 
-// swiftlint:disable:next blanket_disable_command
-// swiftlint:disable let_var_whitespace
-
 @AutoApply
 struct DiscouragedDirectInitConfiguration: SeverityBasedRuleConfiguration {
     typealias Parent = DiscouragedDirectInitRule

diff --git a/Source/SwiftLintBuiltInRules/Rules/RuleConfigurations/IndentationWidthConfiguration.swift b/Source/SwiftLintBuiltInRules/Rules/RuleConfigurations/IndentationWidthConfiguration.swift
@@ -1,8 +1,5 @@
 import SwiftLintCore
 
-// swiftlint:disable:next blanket_disable_command
-// swiftlint:disable let_var_whitespace
-
 @AutoApply
 struct IndentationWidthConfiguration: SeverityBasedRuleConfiguration {
     typealias Parent = IndentationWidthRule

diff --git a/...e/SwiftLintBuiltInRules/Rules/RuleConfigurations/TestCaseAccessibilityConfiguration.swift b/...e/SwiftLintBuiltInRules/Rules/RuleConfigurations/TestCaseAccessibilityConfiguration.swift
@@ -1,8 +1,5 @@
 import SwiftLintCore
 
-// swiftlint:disable:next blanket_disable_command
-// swiftlint:disable let_var_whitespace
-
 @AutoApply
 struct TestCaseAccessibilityConfiguration: SeverityBasedRuleConfiguration {
     typealias Parent = TestCaseAccessibilityRule

diff --git a/Source/SwiftLintBuiltInRules/Rules/RuleConfigurations/UnitTestConfiguration.swift b/Source/SwiftLintBuiltInRules/Rules/RuleConfigurations/UnitTestConfiguration.swift
@@ -5,9 +5,6 @@ typealias EmptyXCTestMethodConfiguration = UnitTestConfiguration<EmptyXCTestMeth
 typealias SingleTestClassConfiguration = UnitTestConfiguration<SingleTestClassRule>
 typealias NoMagicNumbersConfiguration = UnitTestConfiguration<NoMagicNumbersRule>
 
-// swiftlint:disable:next blanket_disable_command
-// swiftlint:disable let_var_whitespace
-
 @AutoApply
 struct UnitTestConfiguration<Parent: Rule>: SeverityBasedRuleConfiguration {
     @ConfigurationElement(key: "severity")

diff --git a/Source/SwiftLintBuiltInRules/Rules/RuleConfigurations/UnusedDeclarationConfiguration.swift b/Source/SwiftLintBuiltInRules/Rules/RuleConfigurations/UnusedDeclarationConfiguration.swift
@@ -1,8 +1,5 @@
 import SwiftLintCore
 
-// swiftlint:disable:next blanket_disable_command
-// swiftlint:disable let_var_whitespace
-
 @AutoApply
 struct UnusedDeclarationConfiguration: SeverityBasedRuleConfiguration {
     typealias Parent = UnusedDeclarationRule