-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
False positive modifier_order violation when explicit order is not specified #2435
Closed
2 tasks done
Comments
abdulowork
added a commit
to abdulowork/SwiftLint
that referenced
this issue
Nov 9, 2018
…order specified to conclude a violation
abdulowork
added a commit
to abdulowork/SwiftLint
that referenced
this issue
Nov 14, 2018
…order specified to conclude a violation
abdulowork
added a commit
to abdulowork/SwiftLint
that referenced
this issue
Nov 14, 2018
abdulowork
added a commit
to abdulowork/SwiftLint
that referenced
this issue
Nov 15, 2018
abdulowork
added a commit
to abdulowork/SwiftLint
that referenced
this issue
Nov 15, 2018
abdulowork
added a commit
to abdulowork/SwiftLint
that referenced
this issue
Nov 15, 2018
…order specified to conclude a violation
abdulowork
added a commit
to abdulowork/SwiftLint
that referenced
this issue
Nov 15, 2018
abdulowork
added a commit
to abdulowork/SwiftLint
that referenced
this issue
Nov 15, 2018
abdulowork
added a commit
to abdulowork/SwiftLint
that referenced
this issue
Nov 15, 2018
jpsim
pushed a commit
to abdulowork/SwiftLint
that referenced
this issue
Nov 28, 2018
…order specified to conclude a violation
jpsim
pushed a commit
to abdulowork/SwiftLint
that referenced
this issue
Nov 28, 2018
jpsim
pushed a commit
to abdulowork/SwiftLint
that referenced
this issue
Nov 28, 2018
jpsim
pushed a commit
to abdulowork/SwiftLint
that referenced
this issue
Nov 28, 2018
Resolved in #2458 |
sjavora
pushed a commit
to sjavora/SwiftLint
that referenced
this issue
Mar 9, 2019
realm#2458) * realm#2435 - Adjust modifier_order rule to require explicit modifier order specified to conclude a violation * realm#2435 - Move modifier order rule examples to a separate file * realm#2435 - Add modifier interference tests * realm#2435 - Fix whitespaces * Minor edits * Add changelog entry
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
New Issue Checklist
Describe the bug
False positive
modifier_order
violation is reported whenfinal
keyword precedespublic
keyword if order between two is not specified explicitly.As far as I understand the rule it should only validate the ordering between keywords specified by the configuration keyword groups and leave unspecified declarations in place.
Complete output when running SwiftLint, including the stack trace and command used
Here is the config
Here is the output
Environment
swiftlint version
to be sure)?xcode-select -p
)?The text was updated successfully, but these errors were encountered: