-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Can't disable custom rule in nested config file #2441
Labels
bug
Unexpected and reproducible misbehavior.
Comments
abdulowork
added a commit
to abdulowork/SwiftLint
that referenced
this issue
Dec 25, 2018
…n to consider custom rules of a parent of a nested configuration
abdulowork
added a commit
to abdulowork/SwiftLint
that referenced
this issue
Dec 25, 2018
abdulowork
added a commit
to abdulowork/SwiftLint
that referenced
this issue
Dec 25, 2018
abdulowork
added a commit
to abdulowork/SwiftLint
that referenced
this issue
Dec 25, 2018
abdulowork
added a commit
to abdulowork/SwiftLint
that referenced
this issue
Dec 25, 2018
abdulowork
added a commit
to abdulowork/SwiftLint
that referenced
this issue
Dec 25, 2018
abdulowork
added a commit
to abdulowork/SwiftLint
that referenced
this issue
Dec 26, 2018
abdulowork
added a commit
to abdulowork/SwiftLint
that referenced
this issue
Dec 26, 2018
…n to consider custom rules of a parent of a nested configuration
abdulowork
added a commit
to abdulowork/SwiftLint
that referenced
this issue
Dec 26, 2018
abdulowork
added a commit
to abdulowork/SwiftLint
that referenced
this issue
Dec 26, 2018
abdulowork
added a commit
to abdulowork/SwiftLint
that referenced
this issue
Dec 26, 2018
abdulowork
added a commit
to abdulowork/SwiftLint
that referenced
this issue
Dec 26, 2018
abdulowork
added a commit
to abdulowork/SwiftLint
that referenced
this issue
Dec 26, 2018
abdulowork
added a commit
to abdulowork/SwiftLint
that referenced
this issue
Dec 26, 2018
abdulowork
added a commit
to abdulowork/SwiftLint
that referenced
this issue
Jan 9, 2019
…n to consider custom rules of a parent of a nested configuration
abdulowork
added a commit
to abdulowork/SwiftLint
that referenced
this issue
Jan 9, 2019
abdulowork
added a commit
to abdulowork/SwiftLint
that referenced
this issue
Jan 9, 2019
abdulowork
added a commit
to abdulowork/SwiftLint
that referenced
this issue
Jan 9, 2019
abdulowork
added a commit
to abdulowork/SwiftLint
that referenced
this issue
Jan 9, 2019
abdulowork
added a commit
to abdulowork/SwiftLint
that referenced
this issue
Jan 9, 2019
abdulowork
added a commit
to abdulowork/SwiftLint
that referenced
this issue
Jan 9, 2019
jpsim
added a commit
that referenced
this issue
Jan 13, 2019
* #2441 - Pass custom rules identifiers to the enableRules function to consider custom rules of a parent of a nested configuration * #2441 - Add custom rules merge * #2441 - Fix line length violation * #2441 - Add nested configutaion mocks with custom rules * #2441 - Add nested configurations tests for custom rules * #2441 - Disable function body length check * #2441 - Update changelog * Move changelog to appropriate position * Split up and refactor Configuration.init to avoid being too long * Add tests to LinuxMain.swift * Remove redundant protocol conformances Hashable implies Equatable * Fix typo in changelog entry and add another fixed issue URL
Fixed in #2556. |
sjavora
pushed a commit
to sjavora/SwiftLint
that referenced
this issue
Mar 9, 2019
…ealm#2556) * realm#2441 - Pass custom rules identifiers to the enableRules function to consider custom rules of a parent of a nested configuration * realm#2441 - Add custom rules merge * realm#2441 - Fix line length violation * realm#2441 - Add nested configutaion mocks with custom rules * realm#2441 - Add nested configurations tests for custom rules * realm#2441 - Disable function body length check * realm#2441 - Update changelog * Move changelog to appropriate position * Split up and refactor Configuration.init to avoid being too long * Add tests to LinuxMain.swift * Remove redundant protocol conformances Hashable implies Equatable * Fix typo in changelog entry and add another fixed issue URL
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
New Issue Checklist
Describe the bug
When attempting to disable a custom rule defined in a parent configuration from a nested configuration, SwiftLint can't find that rule and prints the message
configuration error: 'my_custom_rule' is not a valid rule identifier
.Complete output when running SwiftLint, including the stack trace and command used
Environment
swiftlint version
to be sure)? 0.27.0xcode-select -p
)?/Applications/Xcode-10.app/Contents/Developer
The text was updated successfully, but these errors were encountered: