Remove @IBOutlet and @IBInspectable from UnusedDeclarationRule #3184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note making this change for folks is not entirely safe. If you remove an IBInspectable definition, without removing it from IB, it just warns in the console, but if you remove an IBOutlet without removing it from IB, it crashes. |
Generated by 🚫 Danger |
|
@jpsim what do you think about this? |
keith
force-pushed
the
ks/remove-unused-attrs
branch
from
0056cdd
to
6e49f12
Compare
jpsim
approved these changes
Nov 4, 2020
Codecov Report
@@ Coverage Diff @@
## master #3184 +/- ##
=======================================
Coverage 90.50% 90.51%
=======================================
Files 420 420
Lines 20555 20555
=======================================
+ Hits 18604 18605 +1
+ Misses 1951 1950 -1
Continue to review full report at Codecov.
|
keith
added a commit
that referenced
this pull request
Nov 16, 2020
The original implementation wasn't tested so it regressed. #3184
keith
added a commit
that referenced
this pull request
Dec 3, 2020
The original implementation wasn't tested so it regressed. #3184
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This list was intended to be things that could have side effects from
being in IB, or just being dynamic, and therefore we cannot tell if they
are used or not. In the case of the 2 attributes I'm removing, they
could be used in IB, but if they aren't used in code, they should still
be considered dead.