indentation_width warning when preprocessor statements are used

[phranck]

New Issue Checklist

• Updated SwiftLint to the latest version
• I searched for existing GitHub issues

Describe the bug

It was fixed in #4066, unfortunately not completely. Please have a look at: #4030 (comment).

[SimplyDanny]

Works on my machine ... 😄

Are you sure the new option is set to false and you are using one of the release candidates for version 0.49.0? The fix is not contained in version 0.48.0 or earlier.

[SwiftNativeDeveloper]

This does not work on my machine and my colleagues. We have both have 0.50.3 installed.

[SimplyDanny]

@SwiftNativeDeveloper, @phranck: Please try swiftlint lint --no-cache and let me know whether the warnings disappear.

[SwiftNativeDeveloper]

@SwiftNativeDeveloper, @phranck: Please try swiftlint lint --no-cache and let me know whether the warnings disappear.

My colleague cleaned derived data and restarted Xcode and that worked for him. Next time we have stuck settings I'll share the --no-cache flag. Thanks!

[phranck]

@SimplyDanny
Unfortunately, this rule still doesn't work.
I have a "Run Script Phase" containing the following:

export PATH="$PATH:/opt/homebrew/bin"
if which swiftlint > /dev/null; then
  swiftlint lint --no-cache
else
  echo "warning: SwiftLint not installed, download from https://github.com/realm/SwiftLint"
fi

I have opt in the rule indentation_width with this setting:

indentation_width:
  include_compiler_directives: false

and I still get the warning:

[SimplyDanny]

Does it work on the plain command line without any Xcode and build scripts involved?

[phranck]

Yes, indeed. There it does. The warnings from screenshot above are from MainView.swift.

[SimplyDanny]

Are you sure the configuration file is taken into account when running SwiftLint as a build step? Maybe try with an explicit --config option.

[phranck]

This is strange. The MyProject.xcodeproj and the .swiftlint.yml are in the same folder. Running swiftlint --no-cache from within this folder everyhting is fine.

Calling the linter in the build phase script with swiftlint --no-cache --config ${PROJECT_DIR}/.swiftlint.yml it doesn't work. ${PROJECT_DIR} points exactly to the folder where MyProject.xcodeproj is and swiftlint is being called from this folder while the build phase script is running. 🤔

[phranck]

Am I the only one still seeing the warnings? 🤔
My current Runs Script Phase looks like this, and still warnings...

export PATH="$PATH:/opt/homebrew/bin"
if which swiftlint > /dev/null; then
  swiftlint --no-cache --config ${PROJECT_DIR}/.swiftlint.yml
else
  echo "warning: SwiftLint not installed, download from https://github.com/realm/SwiftLint"
fi

[SimplyDanny]

Let's wait for the next release and reevaluate then. There definitely was a bug in the caching mechanism that is now fixed and will be available with the next version.