Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce option to ignore indentation of compiler directives in indentation_width rule #4066

Merged
merged 2 commits into from
Aug 10, 2022
Merged

Introduce option to ignore indentation of compiler directives in indentation_width rule #4066

merged 2 commits into from
Aug 10, 2022

Conversation

SimplyDanny
Copy link
Collaborator

No description provided.

@SimplyDanny SimplyDanny linked an issue Aug 7, 2022 that may be closed by this pull request
indentation_width warning when preprocessor statements are used #4030
Closed
2 tasks
@SwiftLintBot
Copy link

SwiftLintBot commented Aug 7, 2022 •
edited
Loading

12 Messages
📖 Linting Aerial with this PR took 1.21s vs 1.17s on master (3% slower)
📖 Linting Alamofire with this PR took 1.38s vs 1.37s on master (0% slower)
📖 Linting Firefox with this PR took 5.79s vs 5.77s on master (0% slower)
📖 Linting Kickstarter with this PR took 8.54s vs 8.39s on master (1% slower)
📖 Linting Moya with this PR took 0.64s vs 0.64s on master (0% slower)
📖 Linting Nimble with this PR took 0.61s vs 0.6s on master (1% slower)
📖 Linting Quick with this PR took 0.3s vs 0.3s on master (0% slower)
📖 Linting Realm with this PR took 9.56s vs 9.83s on master (2% faster)
📖 Linting SourceKitten with this PR took 0.5s vs 0.49s on master (2% slower)
📖 Linting Sourcery with this PR took 2.23s vs 2.18s on master (2% slower)
📖 Linting Swift with this PR took 4.17s vs 4.02s on master (3% slower)
📖 Linting WordPress with this PR took 10.05s vs 10.02s on master (0% slower)

Generated by 🚫 Danger

@SimplyDanny SimplyDanny force-pushed the ignore-indentation-of-pre-processor branch from d7199c6 to a00d0f7 Compare August 9, 2022 20:30
@SimplyDanny SimplyDanny changed the title Ignore indentation of pre-processor statements in indentation_width rule Introduce option to ignore indentation of compiler directives in indentation_width rule Aug 9, 2022
@SimplyDanny SimplyDanny force-pushed the ignore-indentation-of-pre-processor branch from a00d0f7 to f61a696 Compare August 9, 2022 21:01
@SimplyDanny SimplyDanny merged commit 828f369 into realm:master Aug 10, 2022
@SimplyDanny SimplyDanny deleted the ignore-indentation-of-pre-processor branch August 10, 2022 19:52
@phranck phranck mentioned this pull request Aug 23, 2022
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpsim jpsim jpsim approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

indentation_width warning when preprocessor statements are used
3 participants
@SimplyDanny @SwiftLintBot @jpsim