Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make vertical_parameter_alignment_on_call more flexible when closures are used #1642

Merged
merged 1 commit into from
Jun 24, 2017
Merged

Make vertical_parameter_alignment_on_call more flexible when closures are used #1642

merged 1 commit into from
Jun 24, 2017

Conversation

marcelofabri
Copy link
Collaborator

Fixes #1630

// @ileitch can you try this PR and share your thoughts?

@SwiftLintBot
Copy link

1 Warning
⚠️ This PR may need tests.
377 Messages
📖 Linting Aerial with this PR took 0.37s vs 0.34s on master (8% slower)
📖 Linting Alamofire with this PR took 2.25s vs 2.25s on master (0% slower)
📖 This PR fixed a violation in Firefox: /Client/Frontend/Animators/JumpAndSpinAnimator.swift#L32:24: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
📖 This PR fixed a violation in Firefox: /Client/Frontend/Animators/JumpAndSpinAnimator.swift#L29:16: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
📖 This PR fixed a violation in Firefox: /Client/Frontend/AuthenticationManager/PagingPasscodeViewController.swift#L87:12: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
📖 This PR fixed a violation in Firefox: /Client/Frontend/AuthenticationManager/AuthenticationSettingsViewController.swift#L123:13: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
📖 This PR fixed a violation in Firefox: /Client/Frontend/AuthenticationManager/AuthenticationSettingsViewController.swift#L124:13: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
📖 This PR fixed a violation in Firefox: /Client/Frontend/AuthenticationManager/PasscodeViews.swift#L176:12: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
📖 This PR fixed a violation in Firefox: /Client/Frontend/AuthenticationManager/SensitiveViewController.swift#L57:13: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
📖 This PR fixed a violation in Firefox: /Client/Frontend/AuthenticationManager/SensitiveViewController.swift#L62:13: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
📖 This PR fixed a violation in Firefox: /Client/Frontend/Browser/BackForwardListAnimator.swift#L66:20: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
📖 This PR fixed a violation in Firefox: /Client/Frontend/Browser/BackForwardListAnimator.swift#L77:20: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
📖 This PR fixed a violation in Firefox: /Client/Frontend/Browser/ButtonToast.swift#L137:13: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
📖 This PR fixed a violation in Firefox: /Client/Frontend/Browser/ButtonToast.swift#L152:13: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
📖 This PR fixed a violation in Firefox: /Client/Frontend/Browser/BrowserTrayAnimators.swift#L80:12: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
📖 This PR fixed a violation in Firefox: /Client/Frontend/Browser/BrowserTrayAnimators.swift#L181:16: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
📖 This PR fixed a violation in Firefox: /Client/Frontend/Browser/FaviconManager.swift#L72:38: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
📖 This PR fixed a violation in Firefox: /Client/Frontend/Browser/SimpleToast.swift#L51:13: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
📖 This PR fixed a violation in Firefox: /Client/Frontend/Browser/SimpleToast.swift#L64:13: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
📖 This PR fixed a violation in Firefox: /Client/Frontend/Browser/SwipeAnimator.swift#L78:12: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
📖 This PR fixed a violation in Firefox: /Client/Frontend/Browser/SearchViewController.swift#L212:17: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
📖 This PR fixed a violation in Firefox: /Client/Frontend/Browser/SearchViewController.swift#L435:12: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
📖 This PR fixed a violation in Firefox: /Client/Frontend/Browser/TopTabsViewController.swift#L456:12: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
📖 This PR fixed a violation in Firefox: /Client/Frontend/Browser/TabTrayController.swift#L88:20: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
📖 This PR fixed a violation in Firefox: /Client/Frontend/Browser/TabTrayController.swift#L93:24: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
📖 This PR fixed a violation in Firefox: /Client/Frontend/Browser/TabTrayController.swift#L433:12: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
📖 This PR fixed a violation in Firefox: /Client/Frontend/Browser/TabTrayController.swift#L520:28: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
📖 This PR fixed a violation in Firefox: /Client/Frontend/Browser/TabTrayController.swift#L542:28: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
📖 This PR fixed a violation in Firefox: /Client/Frontend/Browser/TabTrayController.swift#L629:12: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
📖 This PR fixed a violation in Firefox: /Client/Frontend/Browser/TabTrayController.swift#L670:9: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
📖 This PR fixed a violation in Firefox: /Client/Frontend/Browser/TabTrayController.swift#L708:12: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
📖 This PR fixed a violation in Firefox: /Client/Frontend/Browser/TabTrayController.swift#L727:16: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
📖 This PR fixed a violation in Firefox: /Client/Frontend/Browser/BrowserViewController.swift#L154:12: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
📖 This PR fixed a violation in Firefox: /Client/Frontend/Browser/BrowserViewController.swift#L283:16: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
📖 This PR fixed a violation in Firefox: /Client/Frontend/Browser/BrowserViewController.swift#L329:12: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
📖 This PR fixed a violation in Firefox: /Client/Frontend/Browser/BrowserViewController.swift#L775:12: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
📖 This PR fixed a violation in Firefox: /Client/Frontend/Browser/BrowserViewController.swift#L790:16: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
📖 This PR fixed a violation in Firefox: /Client/Frontend/Browser/BrowserViewController.swift#L2075:16: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
📖 This PR fixed a violation in Firefox: /Client/Frontend/Browser/URLBarView.swift#L552:12: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
📖 This PR fixed a violation in Firefox: /Client/Frontend/Home/ActivityStreamPanel.swift#L140:12: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
📖 This PR fixed a violation in Firefox: /Client/Frontend/Home/BookmarksPanel.swift#L117:12: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
📖 This PR fixed a violation in Firefox: /Client/Frontend/Home/RecentlyClosedTabsPanel.swift#L82:12: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
📖 This PR fixed a violation in Firefox: /Client/Frontend/Home/HistoryPanel.swift#L100:12: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
📖 This PR fixed a violation in Firefox: /Client/Frontend/Home/ReaderPanel.swift#L241:12: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
📖 This PR fixed a violation in Firefox: /Client/Frontend/Intro/IntroViewController.swift#L342:16: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
📖 This PR fixed a violation in Firefox: /Client/Frontend/Home/RemoteTabsPanel.swift#L519:12: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
📖 This PR fixed a violation in Firefox: /Client/Frontend/Home/TopSitesPanel.swift#L59:16: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
📖 This PR fixed a violation in Firefox: /Client/Frontend/Home/TopSitesPanel.swift#L275:12: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
📖 This PR fixed a violation in Firefox: /Client/Frontend/Menu/MenuPresentationAnimator.swift#L133:16: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
📖 This PR fixed a violation in Firefox: /Client/Frontend/Login Management/LoginListViewController.swift#L242:16: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
📖 This PR fixed a violation in Firefox: /Client/Frontend/Notifications/NotificationRootViewController.swift#L84:12: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
📖 This PR fixed a violation in Firefox: /Client/Frontend/Settings/CustomSearchViewController.swift#L128:12: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
📖 This PR fixed a violation in Firefox: /Client/Frontend/Settings/CustomSearchViewController.swift#L139:12: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
📖 This PR fixed a violation in Firefox: /Client/Frontend/Settings/AppSettingsOptions.swift#L673:13: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
📖 This PR fixed a violation in Firefox: /Client/Frontend/Settings/AppSettingsOptions.swift#L676:13: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
📖 This PR fixed a violation in Firefox: /Client/Frontend/Settings/LoginDetailViewController.swift#L308:16: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
📖 This PR fixed a violation in Firefox: /Client/Utils/FaviconFetcher.swift#L198:17: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
📖 This PR fixed a violation in Firefox: /Extensions/ShareTo/InitialViewController.swift#L46:12: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
📖 This PR fixed a violation in Firefox: /Extensions/ShareTo/InitialViewController.swift#L61:12: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
📖 This PR fixed a violation in Firefox: /Extensions/ShareTo/InitialViewController.swift#L128:12: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
📖 Linting Firefox with this PR took 9.76s vs 9.92s on master (1% faster)
📖 This PR fixed a violation in Kickstarter: /Kickstarter-iOS/Library/DeprecatedWebViewController.swift#L72:12: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
📖 This PR fixed a violation in Kickstarter: /Kickstarter-iOS/Views/Cells/DiscoveryExpandedSelectableRow.swift#L74:7: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
📖 This PR fixed a violation in Kickstarter: /Kickstarter-iOS/Views/Cells/DiscoveryExpandedSelectableRow.swift#L84:32: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
📖 This PR fixed a violation in Kickstarter: /Kickstarter-iOS/Views/Controllers/CommentDialogViewController.swift#L115:10: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
📖 This PR fixed a violation in Kickstarter: /Kickstarter-iOS/Views/Controllers/DashboardProjectsDrawerViewController.swift#L109:10: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
📖 This PR fixed a violation in Kickstarter: /Kickstarter-iOS/Views/Controllers/DashboardProjectsDrawerViewController.swift#L119:10: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
📖 This PR fixed a violation in Kickstarter: /Kickstarter-iOS/Views/Controllers/DashboardProjectsDrawerViewController.swift#L132:10: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
📖 This PR fixed a violation in Kickstarter: /Kickstarter-iOS/Views/Controllers/DiscoveryNavigationHeaderViewController.swift#L69:11: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
📖 This PR fixed a violation in Kickstarter: /Kickstarter-iOS/Views/Controllers/DiscoveryNavigationHeaderViewController.swift#L78:11: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
📖 This PR fixed a violation in Kickstarter: /Kickstarter-iOS/Views/Controllers/DiscoveryNavigationHeaderViewController.swift#L142:9: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
📖 This PR fixed a violation in Kickstarter: /Kickstarter-iOS/Views/Controllers/DiscoveryNavigationHeaderViewController.swift#L227:6: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
📖 This PR fixed a violation in Kickstarter: /Kickstarter-iOS/Views/Controllers/LiveStreamChatViewController.swift#L138:12: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
📖 This PR fixed a violation in Kickstarter: /Kickstarter-iOS/Views/Controllers/RewardPledgeViewController.swift#L690:8: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
📖 This PR fixed a violation in Kickstarter: /Kickstarter-iOS/Views/Controllers/SignupViewController.swift#L200:10: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
📖 This PR fixed a violation in Kickstarter: /Kickstarter-iOS/Views/Controllers/SettingsViewController.swift#L481:14: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
📖 This PR fixed a violation in Kickstarter: /Kickstarter-iOS/Views/Controllers/ThanksViewController.swift#L192:12: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
📖 This PR fixed a violation in Kickstarter: /Kickstarter-iOS/Views/Controllers/ThanksViewController.swift#L194:12: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
📖 This PR fixed a violation in Kickstarter: /Kickstarter-iOS/Views/DashboardTitleView.swift#L90:10: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
📖 This PR fixed a violation in Kickstarter: /Kickstarter-iOS/Views/Controllers/VideoViewController.swift#L86:12: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
📖 This PR fixed a violation in Kickstarter: /Kickstarter-iOS/Views/Controllers/UpdateDraftViewController.swift#L241:10: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
📖 Linting Kickstarter with this PR took 14.16s vs 14.3s on master (0% faster)
📖 This PR fixed a violation in Moya: /Sources/Moya/MoyaProvider+Internal.swift#L108:20: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
📖 Linting Moya with this PR took 0.66s vs 0.65s on master (1% slower)
📖 This PR fixed a violation in Nimble: /Sources/Nimble/Matchers/PostNotification.swift#L54:16: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
📖 This PR fixed a violation in Nimble: /Tests/NimbleTests/Matchers/ContainElementSatisfyingTest.swift#L58:16: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
📖 This PR fixed a violation in Nimble: /Tests/NimbleTests/Matchers/ContainElementSatisfyingTest.swift#L83:16: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
📖 Linting Nimble with this PR took 1.3s vs 1.31s on master (0% faster)
📖 Linting Quick with this PR took 0.42s vs 0.43s on master (2% faster)
📖 This PR fixed a violation in Realm: /RealmSwift/Tests/MigrationTests.swift#L603:51: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
📖 Linting Realm with this PR took 1.99s vs 1.97s on master (1% slower)
📖 This PR fixed a violation in SourceKitten: /Source/SourceKittenFramework/Request.swift#L70:16: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
📖 This PR fixed a violation in SourceKitten: /Source/SourceKittenFramework/Request.swift#L82:16: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
📖 Linting SourceKitten with this PR took 0.85s vs 0.84s on master (1% slower)
📖 This PR fixed a violation in Sourcery: /Sourcery/Sourcery.swift#L298:30: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
📖 This PR fixed a violation in Sourcery: /Sourcery/Sourcery.swift#L300:12: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
📖 This PR fixed a violation in Sourcery: /Sourcery/Sourcery.swift#L354:30: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
📖 This PR fixed a violation in Sourcery: /Sourcery/Sourcery.swift#L356:12: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
📖 This PR fixed a violation in Sourcery: /SourceryRuntime/Sources/Type.swift#L62:12: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
📖 Linting Sourcery with this PR took 2.73s vs 2.69s on master (1% slower)
📖 Linting Swift with this PR took 9.0s vs 9.05s on master (0% faster)
📖 This PR fixed a violation in WordPress: /WordPress/Classes/Extensions/FLAnimatedImageView+Cache.swift#L25:49: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
📖 This PR fixed a violation in WordPress: /WordPress/Classes/Extensions/UIImageView+Networking.swift#L42:13: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
📖 This PR fixed a violation in WordPress: /WordPress/Classes/Extensions/PHAsset+Exporters.swift#L139:16: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
📖 This PR fixed a violation in WordPress: /WordPress/Classes/Extensions/UIView+Animations.swift#L78:12: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
📖 This PR fixed a violation in WordPress: /WordPress/Classes/Extensions/UIView+Animations.swift#L95:16: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
📖 This PR fixed a violation in WordPress: /WordPress/Classes/Extensions/UIView+Animations.swift#L92:12: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
📖 This PR fixed a violation in WordPress: /WordPress/Classes/Extensions/UIView+Animations.swift#L107:12: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
📖 This PR fixed a violation in WordPress: /WordPress/Classes/Extensions/UIView+Animations.swift#L118:12: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
📖 This PR fixed a violation in WordPress: /WordPress/Classes/Extensions/UIView+Animations.swift#L132:12: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
📖 This PR fixed a violation in WordPress: /WordPress/Classes/Extensions/UINavigationController+SplitViewFullscreen.swift#L85:12: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
📖 This PR fixed a violation in WordPress: /WordPress/Classes/Networking/DomainsServiceRemote.swift#L22:16: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
📖 This PR fixed a violation in WordPress: /WordPress/Classes/Networking/NotificationSettingsServiceRemote.swift#L37:13: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
📖 This PR fixed a violation in WordPress: /WordPress/Classes/Networking/NotificationSettingsServiceRemote.swift#L61:13: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
📖 This PR fixed a violation in WordPress: /WordPress/Classes/Networking/NotificationSettingsServiceRemote.swift#L106:13: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
📖 This PR fixed a violation in WordPress: /WordPress/Classes/Networking/NotificationSettingsServiceRemote.swift#L128:13: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
📖 This PR fixed a violation in WordPress: /WordPress/Classes/Networking/NotificationSyncServiceRemote.swift#L78:12: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
📖 This PR fixed a violation in WordPress: /WordPress/Classes/Networking/NotificationSyncServiceRemote.swift#L102:12: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
⚠️ Danger found 377 violations with this PR. Due to GitHub's max issue comment size, the number shown has been truncated to 118.

Generated by 🚫 Danger

@codecov-io
Copy link

Codecov Report

Merging #1642 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1642      +/-   ##
==========================================
+ Coverage   88.06%   88.08%   +0.02%     
==========================================
  Files         196      196              
  Lines        9817     9838      +21     
==========================================
+ Hits         8645     8666      +21     
  Misses       1172     1172
Impacted Files Coverage Δ
...k/Rules/VerticalParameterAlignmentOnCallRule.swift 97.1% <100%> (+1.26%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 105fbb5...a69f5e2. Read the comment docs.

@marcelofabri marcelofabri merged commit 0c02020 into realm:master Jun 24, 2017
@marcelofabri marcelofabri deleted the bugfix-1630 branch June 24, 2017 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants