Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parallel autocorrect #1679

Merged
merged 1 commit into from
Jul 17, 2017
Merged

Parallel autocorrect #1679

merged 1 commit into from
Jul 17, 2017

Conversation

marcelofabri
Copy link
Collaborator

Fix #1578

@SwiftLintBot
Copy link

SwiftLintBot commented Jul 15, 2017

12 Messages
📖 Linting Aerial with this PR took 0.37s vs 0.34s on master (8% slower)
📖 Linting Alamofire with this PR took 2.27s vs 2.28s on master (0% faster)
📖 Linting Firefox with this PR took 9.9s vs 9.91s on master (0% faster)
📖 Linting Kickstarter with this PR took 14.08s vs 14.3s on master (1% faster)
📖 Linting Moya with this PR took 0.64s vs 0.64s on master (0% slower)
📖 Linting Nimble with this PR took 1.29s vs 1.29s on master (0% slower)
📖 Linting Quick with this PR took 0.42s vs 0.43s on master (2% faster)
📖 Linting Realm with this PR took 1.97s vs 1.98s on master (0% faster)
📖 Linting SourceKitten with this PR took 0.85s vs 0.83s on master (2% slower)
📖 Linting Sourcery with this PR took 2.72s vs 2.67s on master (1% slower)
📖 Linting Swift with this PR took 9.39s vs 9.54s on master (1% faster)
📖 Linting WordPress with this PR took 9.37s vs 9.46s on master (0% faster)

Generated by 🚫 Danger

@codecov-io
Copy link

codecov-io commented Jul 15, 2017

Codecov Report

Merging #1679 into master will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1679      +/-   ##
==========================================
- Coverage   87.32%   87.31%   -0.01%     
==========================================
  Files         201      201              
  Lines       10006    10007       +1     
==========================================
  Hits         8738     8738              
- Misses       1268     1269       +1
Impacted Files Coverage Δ
Source/swiftlint/Commands/AutoCorrectCommand.swift 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e34f98...4dcbc5e. Read the comment docs.

@marcelofabri marcelofabri requested a review from jpsim July 15, 2017 20:52
Copy link
Collaborator

@jpsim jpsim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could've sworn I had a reason for not doing this... 🤔

I vaguely recall it not being safe to do, but I can't think of why anymore.

It's definitely not safe to parallelize the corrections of multiple rules in a single file, but it should be safe to parallelize correcting multiple files concurrently. 👍

@marcelofabri marcelofabri merged commit 9edde88 into realm:master Jul 17, 2017
@marcelofabri
Copy link
Collaborator Author

🚢

@marcelofabri marcelofabri deleted the parallel-autocorrect branch July 17, 2017 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants