Perform major refactor of rule description, identifiers and examples #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think it makes sense to be static, even though it makes the caller's syntax a little less nice. |
|
Cool, any other feedback? |
|
Nope, code looks good to me! Keith Smiley On 11/04, JP Simard wrote:
|
jpsim
added a commit
that referenced
this pull request
Nov 4, 2015
Perform major refactor of rule description, identifiers and examples
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #183. This deduplicates a lot of information and drastically helps with readability & rule maintenance IMO.
Do you have any thoughts on this @keith? One thing I'm not convinced about is the fact that
Rule.descriptionis a static method, but my rationale there is to avoid needing an instance of the type when you just need its description.