Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix disabling superfluous_disable_command rule #1891

Merged
merged 1 commit into from
Oct 6, 2017
Merged

Fix disabling superfluous_disable_command rule #1891

merged 1 commit into from
Oct 6, 2017

Conversation

marcelofabri
Copy link
Collaborator

Fixes #1890

// cc @bdorfman-stripe

@SwiftLintBot
Copy link

12 Messages
📖 Linting Aerial with this PR took 0.42s vs 0.38s on master (10% slower)
📖 Linting Alamofire with this PR took 2.87s vs 2.72s on master (5% slower)
📖 Linting Firefox with this PR took 11.87s vs 11.11s on master (6% slower)
📖 Linting Kickstarter with this PR took 18.53s vs 17.68s on master (4% slower)
📖 Linting Moya with this PR took 1.27s vs 1.27s on master (0% slower)
📖 Linting Nimble with this PR took 1.65s vs 1.61s on master (2% slower)
📖 Linting Quick with this PR took 0.49s vs 0.5s on master (2% faster)
📖 Linting Realm with this PR took 2.78s vs 2.74s on master (1% slower)
📖 Linting SourceKitten with this PR took 0.95s vs 0.94s on master (1% slower)
📖 Linting Sourcery with this PR took 4.0s vs 4.07s on master (1% faster)
📖 Linting Swift with this PR took 11.67s vs 11.92s on master (2% faster)
📖 Linting WordPress with this PR took 10.7s vs 10.82s on master (1% faster)

Generated by 🚫 Danger

@codecov-io
Copy link

Codecov Report

Merging #1891 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1891      +/-   ##
==========================================
+ Coverage   88.75%   88.76%   +0.01%     
==========================================
  Files         238      238              
  Lines       11710    11723      +13     
==========================================
+ Hits        10393    10406      +13     
  Misses       1317     1317
Impacted Files Coverage Δ
Source/SwiftLintFramework/Models/Linter.swift 81.81% <100%> (+1.01%) ⬆️
Tests/SwiftLintFrameworkTests/CommandTests.swift 98.55% <100%> (+0.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 881208a...96c6a13. Read the comment docs.

Copy link
Collaborator

@jpsim jpsim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At some point it might be nice to refactor the rule to be a real rule, conforming to the Rule protocol, which would hopefully avoid special casing it. But for now, this is ok. 👍

@marcelofabri marcelofabri merged commit 390e5ca into realm:master Oct 6, 2017
@marcelofabri marcelofabri deleted the bugfix-1890 branch October 6, 2017 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants